Feature/sycl context

[oleksandr-pavlyk]

@diptorupd This is a WIP to add SyclContext constructors, including those multi-device context.

In [1]: import dpctl

In [2]: dpctl.SyclContext() # default device context
Out[2]: <dpctl._sycl_context.SyclContext at 0x7f987c330770>

In [3]: Out[2].get_devices()
Out[3]: [<dpctl.SyclDevice [backend_type.level_zero, device_type.gpu,  Intel(R) Graphics [0x9bca]] at 0x7f986c81b0b0>]

In [4]: dpctl.SyclContext("opencl:cpu")
Out[4]: <dpctl._sycl_context.SyclContext at 0x7f986c84e630>

In [5]: Out[4].get_devices()
Out[5]: [<dpctl.SyclDevice [backend_type.opencl, device_type.cpu,  Intel(R) Core(TM) i7-10710U CPU @ 1.10GHz] at 0x7f986c8157b0>]

This works

In [6]: d = dpctl.SyclDevice("opencl:cpu")

In [7]: ctx = dpctl.SyclContext(d)

In [9]: q = dpctl.SyclQueue(ctx, d)

In [10]: q
Out[10]: <dpctl.SyclQueue at 0x7f985b58ac30>

In [11]: ctx
Out[11]: <dpctl._sycl_context.SyclContext at 0x7f986c84e330>

In [12]: q.get_sycl_context()
Out[12]: <dpctl._sycl_context.SyclContext at 0x7f986c84e330>

In [13]: q.get_sycl_device()
Out[13]: <dpctl.SyclDevice [backend_type.opencl, device_type.cpu,  Intel(R) Core(TM) i7-10710U CPU @ 1.10GHz] at 0x7f986c7fcfb0>

In [14]: ctx.get_devices()
Out[14]: [<dpctl.SyclDevice [backend_type.opencl, device_type.cpu,  Intel(R) Core(TM) i7-10710U CPU @ 1.10GHz] at 0x7f984806bcf0>]

In [15]: d
Out[15]: <dpctl.SyclDevice [backend_type.opencl, device_type.cpu,  Intel(R) Core(TM) i7-10710U CPU @ 1.10GHz] at 0x7f986c7fcfb0>

However, when using different instances of device, it does not work:

In [16]: dpctl.SyclQueue( dpctl.SyclContext(dpctl.select_cpu_device()), dpctl.select_cpu_device())
Queue cannot be constructed with the given context and device as the context does not contain the given device. -33 (CL_INVALID_DEVICE)
---------------------------------------------------------------------------
SyclQueueCreationError                    Traceback (most recent call last)
<ipython-input-16-9313ae43729f> in <module>()
----> 1 dpctl.SyclQueue( dpctl.SyclContext(dpctl.select_cpu_device()), dpctl.select_cpu_device())

~/work/dpctl/dpctl/_sycl_queue.pyx in dpctl._sycl_queue.SyclQueue.__cinit__()
    230                 if len_args == 2:
    231                     arg = args
--> 232                 raise SyclQueueCreationError(
    233                     "SYCL Queue failed to be created from '{}'.".format(arg)
    234                 )

SyclQueueCreationError: SYCL Queue failed to be created from '(<dpctl._sycl_context.SyclContext object at 0x7f986c84ee10>, <dpctl.SyclDevice [backend_type.opencl, device_type.cpu,  Intel(R) Core(TM) i7-10710U CPU @ 1.10GHz] at 0x7f9848071eb0>)'.

[oleksandr-pavlyk]

Minimal example:

In [4]: d = dpctl.select_cpu_device()

In [5]: ctx_ok =  dpctl.SyclContext(d)

In [6]: ctx_bad = dpctl.SyclContext(dpctl.select_cpu_device())

In [7]: dpctl.SyclQueue(ctx_ok, d)
Out[7]: <dpctl.SyclQueue at 0x7fbf4c2f50a0>

In [8]: dpctl.SyclQueue(ctx_bad, d)
Queue cannot be constructed with the given context and device as the context does not contain the given device. -33 (CL_INVALID_DEVICE)
---------------------------------------------------------------------------
SyclQueueCreationError                    Traceback (most recent call last)
<ipython-input-8-976f72760c0f> in <module>()
----> 1 dpctl.SyclQueue(ctx_bad, d)

/repos/dpctl/dpctl/_sycl_queue.pyx in dpctl._sycl_queue.SyclQueue.__cinit__()
    230                 if len_args == 2:
    231                     arg = args
--> 232                 raise SyclQueueCreationError(
    233                     "SYCL Queue failed to be created from '{}'.".format(arg)
    234                 )

SyclQueueCreationError: SYCL Queue failed to be created from '(<dpctl._sycl_context.SyclContext object at 0x7fbf8c04fc90>, <dpctl.SyclDevice [backend_type.opencl, device_type.cpu,  Intel(R) Core(TM) i7-10710U CPU @ 1.10GHz] at 0x7fbf876d7cb0>)'.

[diptorupd]

@oleksandr-pavlyk Please rebase on top of #338.

[oleksandr-pavlyk]

@oleksandr-pavlyk Please rebase on top of #338.

I think it is better for #338 to get merged into master, and for me to merge master into this branch. If the intent is to experiment with #338, then I can always merge the associated branch into this one locally to test.

Have 2021 update 2 been released yet?

[oleksandr-pavlyk]

@oleksandr-pavlyk Please rebase on top of #338.

I think it is better for #338 to get merged into master, and for me to merge master into this branch. If the intent is to experiment with #338, then I can always merge the associated branch into this one locally to test.

Have 2021 update 2 been released yet?

Merged #338 here.

[oleksandr-pavlyk]

I think this PR is ready. SyclContext constructor is in place, tests are in place.

Linux tests passed. Windows - pytest run seg-faults:

  tests/test_dparray.py::Test_dparray::test_dparray_T <- ..\_test_env\lib\site-packages\dpctl\tests\test_dparray.py
  tests.test_dparray.Test_dparray.test_dparray_T
  Fatal Python error: Aborted

[diptorupd]

@oleksandr-pavlyk Please move the changes to sycl_queue.pyx and sycl_platform.pyx and related pxd files into a separate PR. Apart from that some minor changes that I found.

[oleksandr-pavlyk]

@oleksandr-pavlyk Please move the changes to sycl_queue.pyx and sycl_platform.pyx and related pxd files into a separate PR.

Because of several merging that resolved conflicts, it is an involved operation. I will attempt it, but frankly I see little value in doing this exercise.

[diptorupd]

@oleksandr-pavlyk Please move the changes to sycl_queue.pyx and sycl_platform.pyx and related pxd files into a separate PR.

Because of several merging that resolved conflicts, it is an involved operation. I will attempt it, but frankly I see little value in doing this exercise.

Just a suggestion. Let us not bother if it is too involved.

[diptorupd]

Thanks Sasha!