Static method of _Memory to create from external allocation #430

oleksandr-pavlyk · 2021-05-05T23:27:39Z

Method takes USMRef, number of bytes and queue reference.

If USMRef is bound to context in the queue and USM type comes
back not 'unknown', appropriate MemoryUSM* object is created
which assumes ownership of this memory.

Optional memory_owner keyword argument may be specified to set
the recorded reference object to something other than None (signaling
that _Memory is responsible for memory deallocation).

This can be used to create MemoryUSM* Python object from natively
allocated memory, populate it, but leave deallocation to the caller.
It could also be set to a PyCapsule object that carries a custom deleter.

.flake8

dpctl/memory/_memory.pxd

dpctl/memory/_memory.pyx

Method takes USMRef, number of bytes and queue reference. If USMRef is bound to context in the queue and USM type comes back not 'unknown', appropriate MemoryUSM* object is created which assumes ownership of this memory. Optional `memory_owner` keyword argument may be specified to set the recorded reference object to something other than None (signaling that _Memory is responsible for memory deallocation). This can be used to create MemoryUSM* Python object from natively allocated memory, populate it, but leave deallocation to the caller. It could also be set to a PyCapsule object that carries a custom deleter.

dpctl/memory/_memory.pyx

diptorupd · 2021-05-06T15:41:06Z

dpctl-capi/source/dpctl_sycl_usm_interface.cpp

+    if (!QRef) {
+        std::cerr << "Input QRef is nullptr\n";
+        return nullptr;
+    }
    auto Q = unwrap(QRef);
    auto Ptr = malloc_host(size, *Q);


Should we not check for an exception here? At least a bad_alloc exception?

dpctl-capi/source/dpctl_sycl_usm_interface.cpp

oleksandr-pavlyk · 2021-05-06T18:06:45Z

CI failure is network related, timing out when trying to retrieve NumPy for pip installation

pip._vendor.urllib3.exceptions.ReadTimeoutError: HTTPSConnectionPool(host='binstar-cio-packages-prod.s3.amazonaws.com', port=443): Read timed out.

oleksandr-pavlyk requested a review from diptorupd May 5, 2021 23:27

oleksandr-pavlyk force-pushed the feature/create_MemoryObject_from_external_allocation branch from 5b537af to 1676f34 Compare May 6, 2021 00:03