Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/so versioning #482

Merged
merged 2 commits into from
May 28, 2021
Merged

Feature/so versioning #482

merged 2 commits into from
May 28, 2021

Conversation

oleksandr-pavlyk
Copy link
Collaborator

Reenabled so-versioning and tweaked setup commands to correctly copy symbolic links on Linux

@oleksandr-pavlyk
Removed DPCLSyclInterface library from MANIFEST.in
529947e 
Manifest is meant for source distributions, and binary libraries
does not belong there.

Added custom build_py step to copy shared object library from install/
to build_lib folder (build/lib.cpython-..../dpctl)

Added custom post-build step to install command to remove hard links
of versioned shared object library on linux, and recopy them from
build_lib to installation folder.
@coveralls
Copy link
Collaborator

coveralls commented May 28, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 60.917% when pulling bc4b924 on feature/so-versioning into 76680ff on master.

@oleksandr-pavlyk oleksandr-pavlyk force-pushed the feature/so-versioning branch from 237fd10 to bc4b924 Compare May 28, 2021 03:02
@oleksandr-pavlyk
Copy link
Collaborator Author

oleksandr-pavlyk commented May 28, 2021 •
edited
Loading

Using 3.7 artifact built by CI:

(w) [23:04:12 nuc04 tmp]$ ls
dpctl-0.8.0-py37hf4177b6_4.tar.bz2

(w) [23:04:13 nuc04 tmp]$ tar xf dpctl-0.8.0-py37hf4177b6_4.tar.bz2
(w) [23:04:18 nuc04 tmp]$ ls
dpctl-0.8.0-py37hf4177b6_4.tar.bz2  info  lib
(w) [23:04:24 nuc04 tmp]$ ls -l lib/python3.7/site-packages/dpctl/libDPCTL*
lrwxrwxrwx 1 usr group     28 May 27 22:38 lib/python3.7/site-packages/dpctl/libDPCTLSyclInterface.so -> libDPCTLSyclInterface.so.0.8
lrwxrwxrwx 1 usr group     28 May 27 22:38 lib/python3.7/site-packages/dpctl/libDPCTLSyclInterface.so.0 -> libDPCTLSyclInterface.so.0.8
-rw-r--r-- 1 usr group 197840 May 27 22:38 lib/python3.7/site-packages/dpctl/libDPCTLSyclInterface.so.0.8

Mission accomplished.

@diptorupd
Copy link
Contributor

Using 3.7 artifact built by CI:

(w) [23:04:12 nuc04 tmp]$ ls
dpctl-0.8.0-py37hf4177b6_4.tar.bz2

(w) [23:04:13 nuc04 tmp]$ tar xf dpctl-0.8.0-py37hf4177b6_4.tar.bz2
(w) [23:04:18 nuc04 tmp]$ ls
dpctl-0.8.0-py37hf4177b6_4.tar.bz2  info  lib
(w) [23:04:24 nuc04 tmp]$ ls -l lib/python3.7/site-packages/dpctl/libDPCTL*
lrwxrwxrwx 1 usr group     28 May 27 22:38 lib/python3.7/site-packages/dpctl/libDPCTLSyclInterface.so -> libDPCTLSyclInterface.so.0.8
lrwxrwxrwx 1 usr group     28 May 27 22:38 lib/python3.7/site-packages/dpctl/libDPCTLSyclInterface.so.0 -> libDPCTLSyclInterface.so.0.8
-rw-r--r-- 1 usr group 197840 May 27 22:38 lib/python3.7/site-packages/dpctl/libDPCTLSyclInterface.so.0.8

Mission accomplished.

Indeed 👍 great job peeling through the onion layers

@diptorupd diptorupd merged commit 0951961 into master May 28, 2021
@diptorupd diptorupd deleted the feature/so-versioning branch May 28, 2021 15:47
@diptorupd diptorupd mentioned this pull request May 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diptorupd diptorupd diptorupd approved these changes

@PokhodenkoSA PokhodenkoSA Awaiting requested review from PokhodenkoSA

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oleksandr-pavlyk @coveralls @diptorupd