-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a test that retrieved DPCPP compiled kernel and submits them via DPCTLQueue_SubmitRange #499
Conversation
0950b16
to
dbab823
Compare
dbab823
to
d3cc5a4
Compare
Even though, logically, the Thus, duplicating these captured values via |
…ernel test_sycl_queue_submit.cpp uses dpcpp_kernel to get kernels and submit them using DPCTLQueue_SubmitRange, and _SubmitNDRange in the future. This does not work with coverage turned off due to LLVM version incompatibility between IGC and DPCPP.
d3cc5a4
to
cf05f16
Compare
Added tests for TestQueueSubmitNDRange
@diptorupd I have added tests for |
To fix the "generate-coverage" workflow it sufficies to remove linking to The error is
@diptorupd Is there another way to fix it? |
Only include dpcpp_kernels.hpp for non-coverage. Only build dpcpp_kernel for non-coverage, and only link it to dpctl_c_api_tests in this case
Failures on Linux are due to OpenCL runtime packages being unavailable on PyPI due to limitation on the size of published packages. So this can be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merging to master as TeamCity CI fails due to dpcpp_cpp_rt package not being there on pypi.
This does not presently work with coverage turned on due to LLVM version discrepancy between IGC and DPC++.
So the test is excluded for the build with coverage.