Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/submit barrier #524

Merged
merged 2 commits into from
Aug 17, 2021
Merged

Feature/submit barrier #524

merged 2 commits into from
Aug 17, 2021

Conversation

oleksandr-pavlyk
Copy link
Collaborator

@oleksandr-pavlyk oleksandr-pavlyk commented Aug 13, 2021

This PR adds 2 c-api functions:

DPCTLSyclEventRef DPCTLQueue_SubmitBarrier(QRef)
DPCTLSyclEventRef DPCTLQueue_SubmitBarrierForEvents(QRef, DPCTLSyclEventRef * deps, size_t n_deps)

and corresponding Python API function SyclQueue.submit_barrier(dependent_events=None).

Docs strings may still use some improvement.

Implements #503

@coveralls
Copy link
Collaborator

coveralls commented Aug 13, 2021

Coverage Status

Coverage decreased (-0.1%) to 64.897% when pulling 484330b on feature/submit_barrier into d1d8d4e on master.

@oleksandr-pavlyk
Copy link
Collaborator Author

The coverage is decreased because relevant tests are excluded due to an issue in DPC++ that is fixed in the forthcoming updated.

@oleksandr-pavlyk
Copy link
Collaborator Author

Internal CI failures are unrelated to these changes and have to do with conda build using newer version of the compiler than the runtime packages used in wheel testing @AndresGuzman-Ballen

I am going to merge this in tomorrow morning.

@oleksandr-pavlyk oleksandr-pavlyk merged commit 8a55469 into master Aug 17, 2021
@oleksandr-pavlyk oleksandr-pavlyk deleted the feature/submit_barrier branch August 17, 2021 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants