Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add install requires #540

Merged
merged 2 commits into from
Aug 20, 2021
Merged

Add install requires #540

merged 2 commits into from
Aug 20, 2021

Conversation

oleksandr-pavlyk
Copy link
Collaborator

This PR adds install_requires=["numpy", "dpcpp_cpp_rt"] keyword argument to setup call.

It also adds requirements.txt and docs/requirements.txt per #398

Imposing minimal version requirement on dpcpp_cpp_rt does not appear possible in setup.py because install_requires must be provided before the build_backend script has a chance to run.

We should add a Python visible function to get the output of DPCTLService_GetDPCPPVersion().

@coveralls
Copy link
Collaborator

Coverage Status

Coverage remained the same at 65.067% when pulling a0929ce on add-install-requires into 73440ac on master.

@oleksandr-pavlyk oleksandr-pavlyk merged commit 6e0a5bb into master Aug 20, 2021
@oleksandr-pavlyk oleksandr-pavlyk deleted the add-install-requires branch August 20, 2021 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants