-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DPCTLQueue_Memcpy, _Prefetch, _Memadvise become asynchronous #557
Conversation
The return value of these functions changed. Declaration, documentation, tests and implementations updated in dpctl-capi/. dpctl/_backend.pxd updated for changed return type. Usages updated accordingly to get the event and wait on it to preserve the behavior for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Does this change need an update/addition to test cases? |
The only change that was needed is in ERef = DPCTLQueue_Memcpy(QRef, dst_ptr, src_ptr, num_bytes);
DPCTLEvent_Wait(ERef);
DPCTLEvent_Delete(ERef); |
9ba603f
to
583fbf7
Compare
@reazulhoque Is this change ok to merge? |
Not yet. I am still getting segfaults when testing Numba-dppy with dpnp. |
@reazulhoque What versions do you use? |
I am using Numba-dppy master and testing locally. This is a matter of updating dpnp glue implementations in Numba-dppy to wait for the memcpy event. |
Locally all tests passed. Created PR in Numba-dppy IntelPython/numba-dpex#529 |
The return value of these functions changed. Declaration, documentation,
tests and implementations updated in dpctl-capi/.
dpctl/_backend.pxd updated for changed return type. Usages updated
accordingly to get the event and wait on it to preserve the behavior
for now.