Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dpctl.device_type.host_device -> dpctl.device_type.host #626

Merged
merged 1 commit into from
Oct 12, 2021

Conversation

oleksandr-pavlyk
Copy link
Collaborator

one stray unrefactored use corrected.

Fixes these two test failures:

FAILED dpctl/tests/test_sycl_device_factory.py::test_get_devices_with_string_args[str_args0] - AttributeError: host_device
FAILED dpctl/tests/test_sycl_device_factory.py::test_get_devices_with_device_type_str[host] - AttributeError: host_device

@coveralls
Copy link
Collaborator

Coverage Status

Coverage increased (+0.4%) to 74.419% when pulling 7b1a61f on fix-test-device-factory into 49ded41 on master.

@oleksandr-pavlyk
Copy link
Collaborator Author

Merging, since only OS compiler workflow runs with host device enabled, but that does not build due to #624 (fixed in #625, but workflow fails pytest due to this issue).

I verified that tests pass locally.

@oleksandr-pavlyk oleksandr-pavlyk merged commit da90ebd into master Oct 12, 2021
@oleksandr-pavlyk oleksandr-pavlyk deleted the fix-test-device-factory branch October 12, 2021 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants