Fix/gh 649 transpose #653
Merged
Fix/gh 649 transpose #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```
In [1]: import dpctl.tensor as dpt, itertools
In [2]: a = dpt.usm_ndarray((2,3))
In [3]: for i,j in itertools.product(range(2), range(3)): a[i, j] = i*3 + j
In [4]: dpt.to_numpy(a)[1:].T
Out[4]:
array([[3.],
[4.],
[5.]])
In [5]: dpt.to_numpy(a[1:].T)
Out[5]:
array([[3.],
[4.],
[5.]])
```
These were similar to those reported in #649
oleksandr-pavlyk
requested review from
diptorupd,
Alexander-Makaryev and
densmirn
densmirn
approved these changes
Nov 8, 2021
oleksandr-pavlyk
added a commit
that referenced
this pull request
Nov 24, 2021
Expanded entry about #653
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #649
The change amounts to
.Ttaking into account the offset. Similarly_real_viewand_imag_viewdo that as well.Tests added.