Implement error_handler function in libsyclinterface/helper #683

vlad-perevezentsev · 2021-11-22T20:59:09Z

This PR adds two overloaded error_handler functions to pass an exception object and output an error.
Change all functions in dpctl_sycl_plaftorm_interface.cpp to use the error_handler.

coveralls · 2021-11-22T21:12:51Z

Coverage increased (+0.4%) to 75.942% when pulling 3e0c061 on vlad-perevezentsev:error_handler into 476c804 on IntelPython:master.

libsyclinterface/source/dpctl_sycl_platform_interface.cpp

libsyclinterface/source/dpctl_sycl_context_interface.cpp

libsyclinterface/helper/include/dpctl_string_utils.hpp

libsyclinterface/helper/include/dpctl_error_handlers.h

libsyclinterface/helper/source/dpctl_error_handlers.cpp

libsyclinterface/source/dpctl_sycl_context_interface.cpp

libsyclinterface/source/dpctl_sycl_device_manager.cpp

libsyclinterface/helper/source/dpctl_error_handlers.cpp

libsyclinterface/helper/include/dpctl_error_handlers.h

libsyclinterface/helper/source/dpctl_error_handlers.cpp

oleksandr-pavlyk

LGTM!

PR history requires cleanup though.

Rename dpctl_async_error_handler to dpctl_error_handlers DPCTL_VERBOSITY env handling is introduced. Recognized values: none (default), error, info Made sure to run coverage tests with DPCTL_VERBOSITY=error The TestDPCTLSyclQueueInterface.CheckPropertyHandling tests captured error stream in its test. Rename error_handler_callback *error_handler to prevert collisions

oleksandr-pavlyk

Summary of history rewriting:

First commit implements error_handler, renames error handler helper file, renames argument name for functions taking async handler callback.

Then there are commits using error_handler in individual dpct_sycl_*.cpp files

vlad-perevezentsev requested a review from oleksandr-pavlyk November 22, 2021 20:59

vlad-perevezentsev self-assigned this Nov 22, 2021

vlad-perevezentsev linked an issue Nov 22, 2021 that may be closed by this pull request

Introduce error handler function to be used in places of std::cerr output #679

Closed

2 tasks

oleksandr-pavlyk requested a review from diptorupd November 22, 2021 21:45

diptorupd reviewed Nov 22, 2021

View reviewed changes

libsyclinterface/source/dpctl_sycl_platform_interface.cpp Outdated Show resolved Hide resolved

oleksandr-pavlyk reviewed Nov 23, 2021

View reviewed changes

libsyclinterface/source/dpctl_sycl_platform_interface.cpp Outdated Show resolved Hide resolved

oleksandr-pavlyk reviewed Nov 23, 2021

View reviewed changes

libsyclinterface/source/dpctl_sycl_platform_interface.cpp Outdated Show resolved Hide resolved

vlad-perevezentsev force-pushed the error_handler branch from 9e0cb3e to 64160ca Compare November 26, 2021 00:02

oleksandr-pavlyk mentioned this pull request Nov 29, 2021

Initial stubs for the error handling overhaul. #630

Closed

oleksandr-pavlyk reviewed Nov 30, 2021

View reviewed changes

libsyclinterface/source/dpctl_sycl_context_interface.cpp Show resolved Hide resolved

oleksandr-pavlyk reviewed Nov 30, 2021

View reviewed changes

libsyclinterface/helper/include/dpctl_string_utils.hpp Show resolved Hide resolved

oleksandr-pavlyk reviewed Nov 30, 2021

View reviewed changes

libsyclinterface/helper/include/dpctl_error_handlers.h Show resolved Hide resolved

oleksandr-pavlyk reviewed Nov 30, 2021

View reviewed changes

libsyclinterface/helper/source/dpctl_error_handlers.cpp Outdated Show resolved Hide resolved

oleksandr-pavlyk reviewed Nov 30, 2021

View reviewed changes

libsyclinterface/source/dpctl_sycl_context_interface.cpp Outdated Show resolved Hide resolved

oleksandr-pavlyk reviewed Nov 30, 2021

View reviewed changes

libsyclinterface/source/dpctl_sycl_device_manager.cpp Show resolved Hide resolved

oleksandr-pavlyk force-pushed the error_handler branch 4 times, most recently from 6040ec4 to 021045d Compare November 30, 2021 18:47