Synchronization functions and USM allocations functions release GIL #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DPCTLQueue_Wait and friends are declared nogil, and their use is moved into `with nogil` context. This allows us to use host_task to decrement reference count on a Python object without introducing a deadlock.
|
View rendered docs @ https://intelpython.github.io/dpctl/pulls/736/index.html |
|
Does it address #170? |
diptorupd
previously approved these changes
Jan 5, 2022
Large USM allocations can be constly, so releasing GIL while invoking them may be a good idea.
|
The latest batch of changes closes #170 |
oleksandr-pavlyk
changed the title
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DPCTLQueue_Waitand friends are declared nogil, and their useis moved into
with nogilcontext.This allows us to use
sycl::host_taskto manipulate reference count on a Python object without introducing a deadlock.Since USM allocation functions are also synchronous and can take some time for
large allocations, we release GIL for them too. We may perhaps revisit this in the future, only release GIL for large enough allocations.