-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dpctl.lsplatform() to output in jupyter notebook #800
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do not change the API public functions. Instead extend the API and change the implementation of the API.
DPCTLPlatformMgr_PrintInfo
calls internal routine to get std::string
and outputs it as before.
DPCTLPlatformMgr_GetInfo
calls internal routine to get std::string
and copies the result into C-style string.
fe8b34b
to
b553fde
Compare
View rendered docs @ https://intelpython.github.io/dpctl/pulls/800/index.html |
@vlad-perevezentsev Thank you for making the requested changes. DPCTLSyclInterface tests for The test would call a function and check that the returned |
2ab98a0
to
b5433f1
Compare
b5433f1
to
34b4d4f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was able to build the coverage workflow manually. I was also able to manually confirm that the original issue of output of dpctl.lsplatform()
not showing in remotely connected jupyter notebook has been fixed.
LGTM! Waiting for the CI to run its course.
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
Closes #796
This PR changes
DPCTLPlatformMgr_PrintInfo
function to returnchar *
instead of outputting it inlibsyclinterface
, and use that to print using CPython.