Remove unnecessary arg member of SyclEvent/_SyclEvent classes #823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This used to solve the problem of keeps Python arguments that SYCL kernels work on to stay "alive" for the duration of kernel execution. This mechanism was them changed to use host_task, but args member was not removed. This should lower the overhead of constructing/destroying SyclEvent objects.
|
View rendered docs @ https://intelpython.github.io/dpctl/pulls/823/index.html |
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This used to solve the problem of keeps Python arguments that
SYCL kernels work on to stay "alive" for the duration of kernel
execution.
This mechanism was them changed to use host_task, but args member
was not removed.
This should lower the overhead of constructing/destroying SyclEvent
objects.