Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated aspects related to atomics, added supported aspects #844

Merged
merged 2 commits into from
May 24, 2022

Conversation

oleksandr-pavlyk
Copy link
Collaborator

From gh-309 only emulated aspect remains unsupported.

The following aspects from gh-309 are now supported

   sycl::aspect::host_debuggable,
   sycl::aspect::atomic64,
   sycl::aspect::usm_atomic_host_allocations,
   sycl::aspect::usm_atomic_shared_allocations,

Removed (due to deprecation in DPC++) aspects are

    int64_base_atomics
    int64_extended_atomics
  • Verified that neither numba-dpex for dpnp make use of removed aspects.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

From gh-309 only emulated aspect remains unsupported.

The following aspects from gh-309 are now supported

   sycl::aspect::host_debuggable,
   sycl::aspect::atomic64,
   sycl::aspect::usm_atomic_host_allocations,
   sycl::aspect::usm_atomic_shared_allocations,

Removed (due to deprecation in DPC++) aspects are
    int64_base_atomics
    int64_extended_atomics
@github-actions
Copy link

@oleksandr-pavlyk
Copy link
Collaborator Author

The public CI fails because conda packages still have DPC++ 2022.0.2. These changes require 2022.1.

@coveralls
Copy link
Collaborator

coveralls commented May 23, 2022

Coverage Status

Coverage decreased (-0.01%) to 82.885% when pulling addaa7f on update-aspects into e132320 on master.

@oleksandr-pavlyk oleksandr-pavlyk merged commit 3340f33 into master May 24, 2022
@oleksandr-pavlyk oleksandr-pavlyk deleted the update-aspects branch May 24, 2022 17:15
@github-actions
Copy link

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants