Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update expected exception type when creating devices #854

Merged
merged 1 commit into from
Jun 28, 2022

Conversation

oleksandr-pavlyk
Copy link
Collaborator

#826 has modified the type of exception raised when dpctl.SyclDevice could not be created from ValueError to dpctl.SyclDeviceCreationError.

Python examples were not updated. Hence the output of the script shows errors on the manual page about device selection.

This PR updates two affected Python example files, device_selection.py and filter_selection.py.

  • Have you provided a meaningful PR description?
  • Have you tested your changes locally for CPU and GPU devices?

@github-actions
Copy link

@coveralls
Copy link
Collaborator

Coverage Status

Coverage remained the same at 81.617% when pulling ce62bb9 on fix-manual-examples into 16ed729 on master.

@oleksandr-pavlyk oleksandr-pavlyk merged commit 42afc0c into master Jun 28, 2022
@oleksandr-pavlyk oleksandr-pavlyk deleted the fix-manual-examples branch June 28, 2022 19:28
@github-actions
Copy link

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants