Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added dpctl.tensor.tril and dpctl.tensor.triu feature #910

Merged
merged 6 commits into from
Sep 17, 2022
Merged

Added dpctl.tensor.tril and dpctl.tensor.triu feature #910

merged 6 commits into from
Sep 17, 2022

Conversation

npolina4
Copy link
Collaborator

@npolina4 npolina4 commented Sep 15, 2022 •
edited by oleksandr-pavlyk
Loading

tril() function returns the lower triangular part of a matrix (or a stack of matrices) x and follows array API spec.
triu() function returns the upper triangular part of a matrix (or a stack of matrices) x and follows array API spec

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@github-actions
Copy link

View rendered docs @ https://intelpython.github.io/dpctl/pulls/910/index.html

@coveralls
Copy link
Collaborator

coveralls commented Sep 15, 2022 •
edited
Loading

Coverage Status

Coverage increased (+0.1%) to 82.02% when pulling b9c560a on added_tril_and_triu into 4344c83 on master.

@github-actions
Copy link

Array API standard conformance tests failed to run for dpctl=0.14.0dev0=py310h8c27c75_109.

oleksandr-pavlyk
oleksandr-pavlyk requested changes Sep 15, 2022
View reviewed changes
dpctl/tensor/_ctors.py Outdated Show resolved Hide resolved
dpctl/tensor/_ctors.py Outdated Show resolved Hide resolved
dpctl/tensor/libtensor/source/tensor_py.cpp Outdated Show resolved Hide resolved
dpctl/tensor/libtensor/source/tensor_py.cpp Outdated Show resolved Hide resolved
dpctl/tensor/libtensor/source/tensor_py.cpp Outdated Show resolved Hide resolved
dpctl/tensor/libtensor/source/tensor_py.cpp Outdated Show resolved Hide resolved
dpctl/tensor/libtensor/source/tensor_py.cpp Outdated Show resolved Hide resolved
dpctl/tensor/libtensor/source/tensor_py.cpp Outdated Show resolved Hide resolved
dpctl/tensor/libtensor/source/tensor_py.cpp Outdated Show resolved Hide resolved
dpctl/tensor/libtensor/source/tensor_py.cpp Outdated Show resolved Hide resolved
oleksandr-pavlyk
oleksandr-pavlyk requested changes Sep 16, 2022
View reviewed changes
dpctl/tensor/_ctors.py Outdated Show resolved Hide resolved
dpctl/tensor/_ctors.py Outdated Show resolved Hide resolved
dpctl/tensor/libtensor/source/tensor_py.cpp Outdated Show resolved Hide resolved
dpctl/tensor/libtensor/source/tensor_py.cpp Outdated Show resolved Hide resolved
dpctl/tensor/libtensor/source/tensor_py.cpp Outdated Show resolved Hide resolved
@npolina4 npolina4 changed the title WIP: Add dpctl.tensor.tril and dpctl.tensor.triu feature Added dpctl.tensor.tril and dpctl.tensor.triu feature Sep 16, 2022
@npolina4 npolina4 closed this Sep 16, 2022
@npolina4 npolina4 reopened this Sep 16, 2022
@npolina4 npolina4 marked this pull request as ready for review September 16, 2022 21:27
@github-actions
Copy link

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@oleksandr-pavlyk oleksandr-pavlyk self-requested a review September 16, 2022 21:51
@github-actions
Copy link

Array API standard conformance tests failed to run for dpctl=0.14.0dev0=py310h8c27c75_114.

@oleksandr-pavlyk oleksandr-pavlyk self-requested a review September 16, 2022 21:55
@github-actions
Copy link

Array API standard conformance tests failed to run for dpctl=0.14.0dev0=py310h8c27c75_114.

oleksandr-pavlyk
oleksandr-pavlyk approved these changes Sep 17, 2022
View reviewed changes
Copy link
Collaborator

@oleksandr-pavlyk oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @npolina4

@oleksandr-pavlyk oleksandr-pavlyk merged commit a197a1d into master Sep 17, 2022
@oleksandr-pavlyk oleksandr-pavlyk deleted the added_tril_and_triu branch September 17, 2022 03:12
@github-actions
Copy link

Array API standard conformance tests failed to run for dpctl=0.14.0dev0=py310h8c27c75_114.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleksandr-pavlyk oleksandr-pavlyk oleksandr-pavlyk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@npolina4 @coveralls @oleksandr-pavlyk