Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed instances of writeable to writable, added docstrings to _flags.pyx #928

Merged
merged 1 commit into from
Oct 11, 2022

Conversation

ndgrigorian
Copy link
Collaborator

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

Instances of writeable have been changed to writable throughout dpctl
Closes #924

Docstrings have been added to _flags.pyx. They are currently only user-accessible by calling help(flags) where flags is an instance of dpctl.tensor.Flags.
Closes #927

@ndgrigorian ndgrigorian linked an issue Oct 10, 2022 that may be closed by this pull request
@coveralls
Copy link
Collaborator

Coverage Status

Coverage remained the same at 82.136% when pulling 5e40d55 on flags-cleanup into 051e473 on master.

@github-actions
Copy link

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.0dev0=py310h8c27c75_165 ran successfully.
Passed: 33
Failed: 801
Skipped: 3138

1 similar comment
@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.0dev0=py310h8c27c75_165 ran successfully.
Passed: 33
Failed: 801
Skipped: 3138

@ndgrigorian ndgrigorian merged commit 1cdc2a6 into master Oct 11, 2022
@github-actions
Copy link

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.0dev0=py310h8c27c75_165 ran successfully.
Passed: 33
Failed: 801
Skipped: 3138

@ndgrigorian ndgrigorian deleted the flags-cleanup branch November 4, 2022 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add property docstrings for USM ndarray flags Rename USM_ARRAY_WRITABLE to USM_ARRAY_WRITABLE
3 participants