Feature/backend specific queues v2 #93

diptorupd · 2020-10-03T21:24:58Z

Rebased on top of master.

…fo::device_type>().

-- Queues now need to be queried using both backend and device type. -- Fix test cases. -- Platform interfaces now can return the list of available backends. -- Fix skiped tests. -- Expand the platform interface to provide backend info. -- Move backend enums to platfrom from context. -- Add comments. -- Store opencl_cpu, opencl_gpu, and level0_gpu queues inside queue manager. -- Fixed enum typedefs, added cython dict to store backends and device types.

About static variables.

- Rename SyclQueueManager to SyclRTManager - Minor stylistic changes: -- reorder functions alphabetically. -- Move all enums into separate file. - Add C API to get backend from queue, and also add a way to check if a queue is the current queue. - Update sycl_core to match C API.

-- Added a way to check if two DPPLSyclQueueRef and the SyclQueue wrappers point to the same sycl queue. -- Same thing for DPPLSyclContextRef and SyclContext.

diptorupd · 2020-10-04T06:11:58Z

Ready for review.

This PR is the last major thing that I wanted to get into Beta 10. Among other things it makes sure we always know what type of back end we are selecting.

Fixes several important issues:
#53
#73
#51
#33
#95
#83

-- default device is always available.

PokhodenkoSA

Small questions and remarks from me. Not worth to block the PR. LGTM.

backends/include/dppl_sycl_queue_interface.h

backends/include/dppl_sycl_queue_manager.h

backends/source/dppl_sycl_context_interface.cpp

backends/source/dppl_sycl_device_interface.cpp

backends/source/dppl_sycl_platform_interface.cpp

backends/tests/test_sycl_queue_manager.cpp

dpctl/tests/test_sycl_kernel_submit.py

oleksandr-pavlyk · 2020-10-05T13:17:45Z

Requires gtest 1.10 to build (I was not able to execute build_for_develop with gtest 1.8)

oleksandr-pavlyk · 2020-10-05T13:22:24Z

Error handling needs to be improved:

In [1]: import dpctl

In [2]: with dpctl.device_context("cpu::0"):
   ...:     print(1)
   ...:
---------------------------------------------------------------------------
KeyError                                  Traceback (most recent call last)
/localdisk/work/opavlyk/repos/dpctl/dpctl/sycl_core.pyx in dpctl._sycl_core._SyclQueueManager._set_as_current_queue()

KeyError: 'cpu'

During handling of the above exception, another exception occurred:

UnsupportedBackendError                   Traceback (most recent call last)
<ipython-input-2-de76f0cd9073> in <module>
----> 1 with dpctl.device_context("cpu::0"):
      2     print(1)
      3

~/.conda/envs/idp/lib/python3.7/contextlib.py in __enter__(self)
    110         del self.args, self.kwds, self.func
    111         try:
--> 112             return next(self.gen)
    113         except StopIteration:
    114             raise RuntimeError("generator didn't yield") from None

/localdisk/work/repos/dpctl/dpctl/sycl_core.pyx in device_context()

/localdisk/work/repos/dpctl/dpctl/sycl_core.pyx in dpctl._sycl_core._SyclQueueManager._set_as_current_queue()

UnsupportedBackendError: Backend can only be opencl or level-0

Note that I am not sure what the arguments of device_context changed too, so I was trying something I though might be sensible.

oleksandr-pavlyk · 2020-10-05T13:26:31Z

Python 3.7.7 (default, Jul 14 2020, 22:02:37)
Type 'copyright', 'credits' or 'license' for more information
IPython 7.17.0 -- An enhanced Interactive Python. Type '?' for help.

In [1]: import dpctl

In [2]: with dpctl.device_context('level0:gpu:0'):
   ...:     print(dpctl.get_current_queue().get_sycl_device().dump_device_info())
   ...:
TBB Warning: The number of workers is currently limited to 11. The request for 31 workers is ignored. Further requests for more workers will be silently ignored until the limit changes.

    Name            Intel(R) Gen9
    Driver version  1.0.17767
    Vendor          Intel(R) Corporation
    Profile         FULL_PROFILE
    Device type     gpu
None

In [3]: with dpctl.device_context('level0:gpu:0'):
   ...:     dpctl.get_current_queue().get_sycl_device().dump_device_info()
   ...:
    Name            Intel(R) Gen9
    Driver version  1.0.17767
    Vendor          Intel(R) Corporation
    Profile         FULL_PROFILE
    Device type     gpu

In [4]: with dpctl.device_context('opencl:gpu:0'):
   ...:     dpctl.get_current_queue().get_sycl_device().dump_device_info()
   ...:
    Name            Intel(R) Gen9 HD Graphics NEO
    Driver version  20.35.17767
    Vendor          Intel(R) Corporation
    Profile         FULL_PROFILE
    Device type     gpu

In [5]:

Notice the TBB warning on the first invocation.

It would be nice if dpctl provided a function to enumerate all possible arguments understood by device_context, even if only to be used to construct an informative error message.

oleksandr-pavlyk · 2020-10-05T14:26:37Z

I think this is good overall, and should be merged asap.

oleksandr-pavlyk

LGTM overall.

oleksandr-pavlyk · 2020-10-05T15:12:35Z

The TBB message is coming from auto ctx = context(d) line in QMgrHelper::init_queues when d is a GPU device.

In [1]: import dpctl

In [2]: with dpctl.device_context('opencl:gpu'):
   ...:     print(1)
   ...:
at the start
before get info
after get info
after get context
before get info
after get info
TBB Warning: The number of workers is currently limited to 11. The request for 31 workers is ignored. Further requests for more workers will be silently ignored until the limit changes.

after get context
before get info
after get info
after get context
before emplace
after emplace
after new
1

oleksandr-pavlyk · 2020-10-05T16:05:21Z

Please do not merge. I root caused the TBB messages, and preparing a fix

Solution is not to create context on devices that are not of the requested device type or not from the requested backend. ``` Python 3.7.7 (default, Jul 14 2020, 22:02:37) Type 'copyright', 'credits' or 'license' for more information IPython 7.17.0 -- An enhanced Interactive Python. Type '?' for help. In [1]: import dpctl In [2]: with dpctl.device_context('opencl:gpu'): ...: print(1) ...: 1 In [3]: with dpctl.device_context('level0:gpu'): ...: print(1) ...: 1 ```

oleksandr-pavlyk · 2020-10-05T16:18:16Z

Ok, I pushed the fix. Please look it over and merge.

…pecifier.

…rupd/dpctl into feature/backend_specific_queues_v2

* CC=clang.exe * CC=clang-cl.exe

diptorupd · 2020-10-05T21:39:24Z

Merging now. Thanks for the reviews!

Diptorup Deb and others added 8 commits October 3, 2020 11:07

rebase wih master.

c338842

Change the QueueManager API to require backend type.

576598a

Aspects do not seem to work well in beta09. Switch to use get_info<in…

cace295

…fo::device_type>().

Update dppl_sycl_queue_manager.cpp

4076520

About static variables.

Move the initializer for queue manager queues to separate functions.

425f4b9

Change how the queue manager creates the context.

fa4f29a

Fix test cases.

5823125

diptorupd requested a review from PokhodenkoSA October 3, 2020 21:24

diptorupd marked this pull request as draft October 3, 2020 21:25

diptorupd force-pushed the feature/backend_specific_queues_v2 branch from 33decb1 to c96c50d Compare October 3, 2020 23:49

Diptorup Deb added 4 commits October 3, 2020 20:20

Add helper functions to get current backend.

14bf63f

bring back has_{cpu|gpu}_queues

fb1fbb2

Return the queue that was set as default. Helps in error checking.

4572588

Equivalency checking helpers.

99f9080

-- Added a way to check if two DPPLSyclQueueRef and the SyclQueue wrappers point to the same sycl queue. -- Same thing for DPPLSyclContextRef and SyclContext.

diptorupd marked this pull request as ready for review October 4, 2020 05:57

diptorupd requested a review from oleksandr-pavlyk October 4, 2020 05:58

diptorupd mentioned this pull request Oct 4, 2020

Skip tests if backend device is not found #73

Closed

This was referenced Oct 4, 2020

Function DPPLCString_Delete deletes char * which expected to be an array #95

Closed

We need to support ctypes uint8 and ulong #83

Closed

Diptorup Deb added 4 commits October 4, 2020 09:21

A current device is always present even outside a device context.

ccb8d4c

-- default device is always available.

Allow program creation only for OpenCL for the time being.

3f92407

Fix errors found for Sergey.

530ae9f

Remove useless except+, as C++ exceptions do not cross C API.

d6bcd74

diptorupd force-pushed the feature/backend_specific_queues_v2 branch from 87f3460 to d6bcd74 Compare October 4, 2020 14:23

PokhodenkoSA approved these changes Oct 5, 2020

View reviewed changes

oleksandr-pavlyk approved these changes Oct 5, 2020

View reviewed changes

oleksandr-pavlyk mentioned this pull request Oct 5, 2020

Add black formatter for Python code #91

Merged

6 tasks

no need to use enum in return type

4e6aabc

Diptorup Deb added 3 commits October 5, 2020 11:41

Rename DPPLSyclBEType to DPPLSyclBackendType. Drop superfluous enum s…

772b97d

…pecifier.

Merge branch 'feature/backend_specific_queues_v2' of github.com:dipto…

c4acc54

…rupd/dpctl into feature/backend_specific_queues_v2

Reformat.

5d6ddc4

This was referenced Oct 5, 2020

We do not need a separate executable for each C-API test case. #99

Closed

Specifying backend for device_context #100

Closed

Add a way for users to enumerate all possible arguments understood by device_context #101

Closed

Fix formatting.

81dd13d

This was referenced Oct 5, 2020

Utility functions to transform enum to string and back. #102

Closed

Queues in DPPL queue manager should share contexts when appropriate #53

Closed

onaAPI beta10 compiler (IntelPython#103)

7586726

* CC=clang.exe * CC=clang-cl.exe

diptorupd merged commit 251f135 into IntelPython:master Oct 5, 2020

diptorupd deleted the feature/backend_specific_queues_v2 branch October 5, 2020 22:10

This was referenced Oct 5, 2020

Change the way dppl is passed the device number. #33

Closed

Test fails if OpenCL CPU driver is missing #51

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/backend specific queues v2 #93

Feature/backend specific queues v2 #93

diptorupd commented Oct 3, 2020

diptorupd commented Oct 4, 2020 •

edited

Loading

PokhodenkoSA left a comment •

edited

Loading

oleksandr-pavlyk commented Oct 5, 2020

oleksandr-pavlyk commented Oct 5, 2020

oleksandr-pavlyk commented Oct 5, 2020

oleksandr-pavlyk commented Oct 5, 2020

oleksandr-pavlyk left a comment

oleksandr-pavlyk commented Oct 5, 2020

oleksandr-pavlyk commented Oct 5, 2020

oleksandr-pavlyk commented Oct 5, 2020 •

edited

Loading

diptorupd commented Oct 5, 2020

Feature/backend specific queues v2 #93

Feature/backend specific queues v2 #93

Conversation

diptorupd commented Oct 3, 2020

diptorupd commented Oct 4, 2020 • edited Loading

PokhodenkoSA left a comment • edited Loading

Choose a reason for hiding this comment

oleksandr-pavlyk commented Oct 5, 2020

oleksandr-pavlyk commented Oct 5, 2020

oleksandr-pavlyk commented Oct 5, 2020

oleksandr-pavlyk commented Oct 5, 2020

oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

oleksandr-pavlyk commented Oct 5, 2020

oleksandr-pavlyk commented Oct 5, 2020

oleksandr-pavlyk commented Oct 5, 2020 • edited Loading

diptorupd commented Oct 5, 2020

diptorupd commented Oct 4, 2020 •

edited

Loading

PokhodenkoSA left a comment •

edited

Loading

oleksandr-pavlyk commented Oct 5, 2020 •

edited

Loading