Skip to content

Commit

Permalink
Revert skipping test_fill_with_numpy_scalar_ndarray
Browse files Browse the repository at this point in the history
Instead now accepts `ValueError` and `TypeError` in addition to `ComplexWarning`
  • Loading branch information
ndgrigorian committed Sep 19, 2024
1 parent c36cf72 commit 151b6a9
Showing 1 changed file with 4 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -274,9 +274,10 @@ def test_fill(self, xp, dtype):
a.fill(1)
return a

@pytest.mark.skip(
"asynchronous fill does not allow numpy scalar array for consistency"
"with dpnp.fill_diagonal"
@testing.with_requires("numpy>=1.24.0")
@testing.for_all_dtypes_combination(("dtype1", "dtype2"))
@testing.numpy_cupy_array_equal(
accept_error=(ValueError, TypeError, ComplexWarning)
)
def test_fill_with_numpy_scalar_ndarray(self, xp, dtype1, dtype2):
a = testing.shaped_arange((2, 3, 4), xp, dtype1)
Expand Down

0 comments on commit 151b6a9

Please sign in to comment.