Fix signed/unsigned compare warnings & small fixes

IntelPython · Nov 28, 2024 · fa3af10 · fa3af10
1 parent 6fc7166
commit fa3af10
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 10 deletions.
diff --git a/dpnp/backend/extensions/statistics/validation_utils.cpp b/dpnp/backend/extensions/statistics/validation_utils.cpp
@@ -138,34 +138,37 @@ void check_num_dims(const array_ptr &arr,
                     const size_t ndim,
                     const array_names &names)
 {
-    if (arr != nullptr && arr->get_ndim() != ndim) {
+    size_t arr_n_dim = arr != nullptr ? arr->get_ndim() : 0;
+    if (arr != nullptr && arr_n_dim != ndim) {
         throw py::value_error("Array " + name_of(arr, names) + " must be " +
                               std::to_string(ndim) + "D, but got " +
-                              std::to_string(arr->get_ndim()) + "D.");
+                              std::to_string(arr_n_dim) + "D.");
     }
 }
 
 void check_max_dims(const array_ptr &arr,
                     const size_t max_ndim,
                     const array_names &names)
 {
-    if (arr != nullptr && arr->get_ndim() > max_ndim) {
+    size_t arr_n_dim = arr != nullptr ? arr->get_ndim() : 0;
+    if (arr != nullptr && arr_n_dim > max_ndim) {
         throw py::value_error(
             "Array " + name_of(arr, names) + " must have no more than " +
             std::to_string(max_ndim) + " dimensions, but got " +
-            std::to_string(arr->get_ndim()) + " dimensions.");
+            std::to_string(arr_n_dim) + " dimensions.");
     }
 }
 
 void check_size_at_least(const array_ptr &arr,
                          const size_t size,
                          const array_names &names)
 {
-    if (arr != nullptr && arr->get_size() < size) {
+    size_t arr_size = arr != nullptr ? arr->get_size() : 0;
+    if (arr != nullptr && arr_size < size) {
         throw py::value_error("Array " + name_of(arr, names) +
                               " must have at least " + std::to_string(size) +
-                              " elements, but got " +
-                              std::to_string(arr->get_size()) + " elements.");
+                              " elements, but got " + std::to_string(arr_size) +
+                              " elements.");
     }
 }
 

diff --git a/dpnp/dpnp_iface_statistics.py b/dpnp/dpnp_iface_statistics.py
@@ -625,9 +625,6 @@ def correlate(a, v, mode="valid"):
     a_casted = dpnp.asarray(a, dtype=supported_dtype, order="C")
     v_casted = dpnp.asarray(v, dtype=supported_dtype, order="C")
 
-    if v.size > a.size:
-        a_casted, v_casted = v_casted, a_casted
-
     r = _run_native_sliding_dot_product1d(a_casted, v_casted, l_pad, r_pad)
 
     if revert: