Skip to content

Conversation

@vlad-perevezentsev
Copy link
Contributor

@vlad-perevezentsev vlad-perevezentsev commented Feb 17, 2023

This PR adds new logic for dpnp.asfarray function to return floating type depending on the device capabilities if the input array has an integer or boolean type.
These changes are necessary to support work on Iris Xe.
Subtask for #1294

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@antonwolfy antonwolfy merged commit 351f50b into IntelPython:master Feb 28, 2023
@vlad-perevezentsev vlad-perevezentsev deleted the fix_asfarray_func branch August 10, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants