Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify asserts in dlpack tests #1310

Merged
merged 4 commits into from
Feb 27, 2023

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Feb 20, 2023

Since #1016 dpctl will use a dedicated queue cache with (context, device) pair.
The cache will be available in dpctl.tensor.from_dlpack, so it will return the same queue for a given device.

Thus the PR is to update corresponding tests in dpnp and simplify the verifications asserts by a common function.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy merged commit bcbff63 into IntelPython:master Feb 27, 2023
@antonwolfy antonwolfy deleted the cached_dev_in_dlpack branch February 27, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants