Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allocate a separate FFT descriptor per FFT compute function #1322

Merged
merged 4 commits into from
Mar 2, 2023

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Feb 28, 2023

Passing the same object of FFT descriptor to FFT compute functions compute_backward() and compute_forward() which are executing in parallel might cause an undefined behavior and race condition.
A possible was to reproduce the issue is to run following dpnp test:

tests/test_sycl_queue.py::test_fft_rfft[opencl:gpu:0-shape0-float32]

The PR proposes to dynamically allocate FFT descriptors and commit every one on queue. The committed descriptors will be separately passed to FFT compute functions executing in parallel.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Feb 28, 2023
@antonwolfy antonwolfy merged commit 7ed9b40 into IntelPython:master Mar 2, 2023
@antonwolfy antonwolfy deleted the rfft_ci_issue branch March 2, 2023 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants