Skip to content

Conversation

@antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Mar 2, 2023

The PR adds a support of missing bool and complex types for dpnp.abs and dpnp.absolute functions.

In case of complex types, oneapi::mkl::vm::abs function to be reused.
In case of bool type, dpnp will return a copy of input array, like numpy does.
For integer types, sycl::abs with a vector of input data will be called.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Mar 2, 2023
@antonwolfy antonwolfy requested review from npolina4 and oleksandr-pavlyk and removed request for oleksandr-pavlyk March 2, 2023 19:27
Copy link
Contributor

@oleksandr-pavlyk oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I only was able to skim through the code

@antonwolfy antonwolfy merged commit 648612d into IntelPython:master Mar 3, 2023
@antonwolfy antonwolfy deleted the abs_complex branch March 3, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants