Skip to content

Reuse dpctl.tensor implementation for dpnp.nonzero() #1330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 6, 2023
Merged

Reuse dpctl.tensor implementation for dpnp.nonzero() #1330

merged 1 commit into from
Mar 6, 2023

Conversation

@antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Mar 6, 2023 •
edited
Loading

The PR reworks dpnp.nonzero implementation to invoke dpctl.tensor.nonzero function for an input array.
Also a missing nonzero method of dpnp_array class is implemented.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Mar 6, 2023
oleksandr-pavlyk
oleksandr-pavlyk approved these changes Mar 6, 2023
View reviewed changes
Copy link
Contributor

@oleksandr-pavlyk oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

vlad-perevezentsev
vlad-perevezentsev approved these changes Mar 6, 2023
View reviewed changes
Copy link
Contributor

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@antonwolfy antonwolfy merged commit a8d7135 into IntelPython:master Mar 6, 2023
@antonwolfy antonwolfy deleted the dpctl_nonzero branch March 6, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vlad-perevezentsev vlad-perevezentsev vlad-perevezentsev approved these changes

+1 more reviewer

@oleksandr-pavlyk oleksandr-pavlyk oleksandr-pavlyk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@antonwolfy antonwolfy

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@antonwolfy @oleksandr-pavlyk @vlad-perevezentsev