Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compilation error with sycl::abs() #1393

Merged
merged 1 commit into from
May 17, 2023
Merged

Fix compilation error with sycl::abs() #1393

merged 1 commit into from
May 17, 2023

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented May 5, 2023 •
edited
Loading

DPC++ 2023.1 declared a return type of sycl::abs() as unsigned one, even when an input type is signed.
With DPC++ 2023.2 the behavior is changed and result type has the same sign as input one now.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this May 5, 2023
@antonwolfy antonwolfy merged commit 25e6b9a into IntelPython:master May 17, 2023
@antonwolfy antonwolfy deleted the fix_compiler_error branch May 17, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleksandr-pavlyk oleksandr-pavlyk oleksandr-pavlyk approved these changes

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@npolina4 npolina4 Awaiting requested review from npolina4

@vtavana vtavana Awaiting requested review from vtavana vtavana is a code owner

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonwolfy @oleksandr-pavlyk