Reuse dpctl.tensor.floor_divide() function. #1427
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonwolfy
reviewed
Jun 13, 2023
antonwolfy
reviewed
Jun 14, 2023
| @@ -767,42 +768,7 @@ def floor_divide(x1, x2, dtype=None, out=None, where=True, **kwargs): | |||
|
|
|||
There was a problem hiding this comment.
please update an example, since the output has different format now
| @@ -147,9 +147,10 @@ def test_divide(self, dtype, lhs, rhs): | |||
| def test_fmod(self, dtype, lhs, rhs): | |||
| self._test_mathematical('fmod', dtype, lhs, rhs) | |||
|
|
|||
| @pytest.mark.usefixtures("allow_fall_back_on_numpy") | |||
| @pytest.mark.parametrize("dtype", get_all_dtypes(no_bool=True, no_complex=True)) | |||
| @pytest.mark.parametrize("dtype", get_all_dtypes(no_complex=True)) | |||
There was a problem hiding this comment.
can we unmute tests from tests/third_party/cupy/math_tests/test_arithmetic.py ?
|
blocked by issue in dpctl #1247 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reused dpctl.tensor.floor_divide() function.
Fixed crash for device without support double precision.
Added tests.
The PR is about to close #1404.