Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin to numpy<1.24 in build_sphinx #1491

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Pin to numpy<1.24 in build_sphinx #1491

merged 1 commit into from
Jul 20, 2023

Conversation

vlad-perevezentsev
Copy link
Collaborator

This PR pines numpy<1.24 to build sphinx documentation. The change is necessary cause cupy uses numpy.bool which expired in version numpy>1.24 NumPy 1.24 Release Notes

 File "/usr/share/miniconda3/envs/docs/lib/python3.9/site-packages/cupyx/scipy/sparse/_index.py", line 22, in <module>
    _bool_scalar_types = (bool, numpy.bool, numpy.bool_)
  File "/usr/share/miniconda3/envs/docs/lib/python3.9/site-packages/numpy/__init__.py", line 305, in __getattr__
    raise AttributeError(__former_attrs__[attr])
AttributeError: module 'numpy' has no attribute 'bool'.
  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vlad-perevezentsev vlad-perevezentsev self-assigned this Jul 20, 2023
antonwolfy
antonwolfy approved these changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @vlad-perevezentsev !

@vlad-perevezentsev vlad-perevezentsev merged commit 6a46e0e into master Jul 20, 2023
@vlad-perevezentsev vlad-perevezentsev deleted the fix_sphinx branch July 20, 2023 21:35
vlad-perevezentsev added a commit that referenced this pull request Aug 1, 2023
@vlad-perevezentsev
Pin to numpy<1.24 in build_sphinx (#1491)
b146475
antonwolfy pushed a commit that referenced this pull request Aug 18, 2023
@vlad-perevezentsev
Update API References and ndarray documentation (#1490)
e3fd477 
* Update API Reference

* Refresh Multi-Dimensional Array section

* Pin to numpy<1.24 in build_sphinx (#1491)

* Make subchapters for ndarray chapter

* Rename Difference with NumPy chapter

* Update Available array data types chapter

* Delete structured data types line

* Add missing docstrings

* Hide empty subchapter of routines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

Assignees

@vlad-perevezentsev vlad-perevezentsev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vlad-perevezentsev @antonwolfy