Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reuse dpctl.tensort.take for dpnp.take #1492

Merged
merged 5 commits into from
Jul 28, 2023
Merged

Reuse dpctl.tensort.take for dpnp.take #1492

merged 5 commits into from
Jul 28, 2023

Conversation

vlad-perevezentsev
Copy link
Collaborator

This PR modifies dpnp.take() implementation to use dpctl.tensor.take() instead of dpnp implementation.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vlad-perevezentsev vlad-perevezentsev self-assigned this Jul 20, 2023
antonwolfy
antonwolfy reviewed Jul 21, 2023
View reviewed changes
dpnp/dpnp_iface_indexing.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_indexing.py Show resolved Hide resolved
dpnp/dpnp_iface_indexing.py Outdated Show resolved Hide resolved
antonwolfy
antonwolfy reviewed Jul 26, 2023
View reviewed changes
dpnp/dpnp_iface_indexing.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_indexing.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_indexing.py Show resolved Hide resolved
dpnp/dpnp_iface_indexing.py Show resolved Hide resolved
antonwolfy
antonwolfy approved these changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great! thank you @vlad-perevezentsev

@antonwolfy antonwolfy merged commit 689831a into master Jul 28, 2023
@antonwolfy antonwolfy deleted the reuse_take branch July 28, 2023 10:55
@antonwolfy antonwolfy mentioned this pull request Aug 23, 2023
Merged
This was referenced Sep 19, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

Assignees

@vlad-perevezentsev vlad-perevezentsev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vlad-perevezentsev @antonwolfy