Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update test_statistic.py to run on Iris Xe #1494

Merged
merged 7 commits into from
Jul 24, 2023
Merged

Update test_statistic.py to run on Iris Xe #1494

merged 7 commits into from
Jul 24, 2023

Conversation

vlad-perevezentsev
Copy link
Collaborator

This PR solves updates tests and backend of some statistic functions to run on Iris Xe which does not support double precision floating point type.
It solves part of #1293

Also it moves get_ret_type_and_func function to dpnp_algo_utils file for common use in cython files

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vlad-perevezentsev vlad-perevezentsev self-assigned this Jul 24, 2023
antonwolfy
antonwolfy reviewed Jul 24, 2023
View reviewed changes
dpnp/dpnp_utils/dpnp_utils_statistics.py Outdated Show resolved Hide resolved
dpnp/dpnp_utils/dpnp_utils_statistics.py Outdated Show resolved Hide resolved
dpnp/backend/kernels/dpnp_krnl_statistics.cpp Outdated Show resolved Hide resolved
tests/test_statistics.py Outdated Show resolved Hide resolved
tests/test_statistics.py Show resolved Hide resolved
antonwolfy
antonwolfy approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thank you @vlad-perevezentsev

@vlad-perevezentsev vlad-perevezentsev merged commit e142b5a into master Jul 24, 2023
@vlad-perevezentsev vlad-perevezentsev deleted the fix_test_statistics branch July 24, 2023 17:45
This was referenced Sep 19, 2023
Closed
Merged
@vlad-perevezentsev vlad-perevezentsev mentioned this pull request Jun 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@npolina4 npolina4 Awaiting requested review from npolina4

Assignees

@vlad-perevezentsev vlad-perevezentsev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vlad-perevezentsev @antonwolfy