Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reuse dpctl.tensor.isnan(), dpctl.tensor.isinf(), and dpctl.tensor.isfinite() functions. #1504

Merged
merged 8 commits into from
Aug 1, 2023
Merged

Reuse dpctl.tensor.isnan(), dpctl.tensor.isinf(), and dpctl.tensor.isfinite() functions. #1504

merged 8 commits into from
Aug 1, 2023

Conversation

npolina4
Copy link
Collaborator

Reused dpctl.tensor.isnan(), dpctl.tensor.isinf(), and dpctl.tensor.isfinite() functions.
Added tests.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

antonwolfy
antonwolfy reviewed Jul 28, 2023
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update also tests/third_party/cupy/logic_tests/test_content.py with removing allow_fall_back_on_numpy fixture and adding complex types

tests/test_logic.py Outdated Show resolved Hide resolved
npolina4
npolina4 commented Jul 31, 2023
View reviewed changes
tests/test_logic.py Outdated Show resolved Hide resolved
antonwolfy
antonwolfy approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @npolina4

@antonwolfy antonwolfy merged commit 70294a3 into master Aug 1, 2023
@antonwolfy antonwolfy deleted the reuse_dpctl_isnan branch August 1, 2023 12:39
@antonwolfy antonwolfy mentioned this pull request Aug 23, 2023
Merged
This was referenced Sep 19, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@npolina4 @antonwolfy