Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leverage dpctl.tensor.all() and dpctl.tensor.any() implementations #1512

Merged
merged 7 commits into from
Aug 16, 2023
Merged

Leverage dpctl.tensor.all() and dpctl.tensor.any() implementations #1512

merged 7 commits into from
Aug 16, 2023

Conversation

vlad-perevezentsev
Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev commented Aug 7, 2023 •
edited
Loading

This PR modifies dpnp.all() and dpnp.any() implementations to use dpctl.tensor.all() and dpctl.tensor.any() instead of dpnp implementations.
It also adds a new test_truth file and expands the scope of tests for public CI.

The PR is open as a draft until #1327(dpctl) is fixed

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vlad-perevezentsev vlad-perevezentsev self-assigned this Aug 7, 2023
@vlad-perevezentsev vlad-perevezentsev changed the title Dpctl all any Leverage dpctl.tensor.all() dpctl.tensor.any() implementations Aug 7, 2023
@vlad-perevezentsev vlad-perevezentsev changed the title Leverage dpctl.tensor.all() dpctl.tensor.any() implementations Leverage dpctl.tensor.all() and dpctl.tensor.any() implementations Aug 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2023 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

antonwolfy
antonwolfy reviewed Aug 7, 2023
View reviewed changes
dpnp/dpnp_iface_logic.py Show resolved Hide resolved
dpnp/dpnp_iface_logic.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_logic.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_logic.py Show resolved Hide resolved
tests/third_party/cupy/logic_tests/test_truth.py Outdated Show resolved Hide resolved
.github/workflows/conda-package.yml Show resolved Hide resolved
@vlad-perevezentsev vlad-perevezentsev marked this pull request as ready for review August 9, 2023 09:16
antonwolfy
antonwolfy approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vlad-perevezentsev LGTM!

@vlad-perevezentsev vlad-perevezentsev merged commit 1650774 into master Aug 16, 2023
@vlad-perevezentsev vlad-perevezentsev deleted the dpctl_all_any branch August 16, 2023 11:52
@antonwolfy antonwolfy mentioned this pull request Aug 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

Assignees

@vlad-perevezentsev vlad-perevezentsev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vlad-perevezentsev @antonwolfy