Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve Arguments in wrong order issue reported by Coverity tool #1513

Merged
merged 4 commits into from
Aug 8, 2023

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Aug 7, 2023

The TR is intended to resolve an issue from Coverity report with "high" severity.

The tool claims that the positions of arguments in the call to mkl_blas::gemm do not match the ordering of the parameters: ldb is passed to lda, lda is passed to ldb.
Actually, the issue is false positive, since local variables lda and ldb are assigning to correct values. But the PR proposes to resolve the reported problem to avoid future misleading.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2023

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@antonwolfy antonwolfy merged commit f86749c into master Aug 8, 2023
@antonwolfy antonwolfy deleted the args_in_wrong_order branch August 8, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants