Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify the tests to align them with the changes in dpctl #1527

Merged
merged 2 commits into from
Aug 19, 2023
Merged

Modify the tests to align them with the changes in dpctl #1527

merged 2 commits into from
Aug 19, 2023

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Aug 19, 2023

Due to the new updates in elementwise function of dpctl #1352, the tests in dpnp are updated to align them with the changes in dpctl.
The changes in dpctl include:

  1. raise ValueError when, there is shape inconsistency between input(s) and output
  2. Memory overlap between inputs and output is allowed
  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavana vtavana self-assigned this Aug 19, 2023
@vtavana vtavana marked this pull request as ready for review August 19, 2023 02:37
@vtavana vtavana requested a review from antonwolfy August 19, 2023 02:38
@github-actions
Copy link
Contributor

github-actions bot commented Aug 19, 2023 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

antonwolfy
antonwolfy approved these changes Aug 19, 2023
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtavana for so quick fix to resolve the test faults. LGTM!

@antonwolfy antonwolfy merged commit 92e9b1c into master Aug 19, 2023
@antonwolfy antonwolfy deleted the modify_tests_to_align_them_with_changes_in_dpctl branch August 19, 2023 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

Assignees

@vtavana vtavana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vtavana @antonwolfy