Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of fallback on numpy in dpnp.asfarray #1542

Merged
merged 9 commits into from
Sep 6, 2023
Merged

Get rid of fallback on numpy in dpnp.asfarray #1542

merged 9 commits into from
Sep 6, 2023

Conversation

npolina4
Copy link
Collaborator

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@github-actions
Copy link
Contributor

github-actions bot commented Aug 28, 2023 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@antonwolfy antonwolfy changed the title SAT-6118 Get rid of fallback on numpy in dpnp.asfarray Get rid of fallback on numpy in dpnp.asfarray Aug 28, 2023
antonwolfy
antonwolfy reviewed Aug 28, 2023
View reviewed changes
dpnp/dpnp_iface_manipulation.py Show resolved Hide resolved
dpnp/dpnp_iface_manipulation.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_manipulation.py Show resolved Hide resolved
dpnp/dpnp_iface_manipulation.py Show resolved Hide resolved
antonwolfy
antonwolfy reviewed Aug 29, 2023
View reviewed changes
dpnp/dpnp_iface_manipulation.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_manipulation.py Outdated Show resolved Hide resolved
tests/skipped_tests.tbl Outdated Show resolved Hide resolved
antonwolfy
antonwolfy approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have only one minor comment. But all other is LGTM! Thank you @npolina4

dpnp/dpnp_iface_manipulation.py Outdated Show resolved Hide resolved
npolina4 and others added 2 commits August 31, 2023 10:41
@npolina4 @antonwolfy
Update dpnp/dpnp_iface_manipulation.py
9949915 
Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com>
@npolina4
Merge branch 'master' into update_asfarray
c0a895c
npolina4 and others added 2 commits September 5, 2023 10:17
@npolina4 @antonwolfy
Update tests/third_party/cupy/manipulation_tests/test_kind.py
ca93f92 
Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com>
@npolina4
Update test_kind.py
3ca9530
antonwolfy
antonwolfy approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@antonwolfy antonwolfy merged commit 7cb3949 into master Sep 6, 2023
@antonwolfy antonwolfy deleted the update_asfarray branch September 6, 2023 17:45
This was referenced Sep 19, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@npolina4 @antonwolfy