Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct return of object type at zero copy #1571

Merged
merged 2 commits into from
Sep 26, 2023
Merged

Conversation

vlad-perevezentsev
Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev commented Sep 26, 2023

This PR solves #1570

A new condition was added to def asarray function by #1526 which means if dpctl returns a zero copy, return the input argument.
This did not consider the case where the input argument is usm_ndarray so it returned usm_ndarray without wrapping it in dpnp.ndarray

This PR updates the condition to return the input argument when dpctl return a zero copy and adds tests.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@github-actions
Copy link
Contributor

github-actions bot commented Sep 26, 2023

View rendered docs @ https://intelpython.github.io/dpnp/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants