Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

re-write dpnp.abs #1575

Merged
merged 2 commits into from
Oct 10, 2023
Merged

re-write dpnp.abs #1575

merged 2 commits into from
Oct 10, 2023

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Oct 2, 2023

The PR changes the implementation of dpnp.abs. This function now invokes oneapi::mkl::vm implementation from pybind11 extension of OneMKL VM if possible or uses dpctl.tensor.abs implementation if not.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavana vtavana self-assigned this Oct 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@vtavana vtavana marked this pull request as ready for review October 2, 2023 19:13
antonwolfy
antonwolfy reviewed Oct 9, 2023
View reviewed changes
dpnp/dpnp_iface_mathematical.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_mathematical.py Show resolved Hide resolved
dpnp/dpnp_iface_mathematical.py Outdated Show resolved Hide resolved
@vtavana vtavana force-pushed the abs_dpctl_to_dpnp branch from a9e824b to a3fa354 Compare October 9, 2023 16:15
@IntelPython IntelPython deleted a comment from antonwolfy Oct 9, 2023
@vtavana vtavana force-pushed the abs_dpctl_to_dpnp branch from 9a1d709 to e33a4db Compare October 9, 2023 20:38
@vtavana
Copy link
Collaborator Author

vtavana commented Oct 9, 2023

To add complex types for oneapi::mkl::vm::abs, we need to update the code to allow output type to be different than input when dispatching happens. We will address it in a separate PR.

antonwolfy
antonwolfy approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @vtavana

@vtavana vtavana merged commit cf7362d into master Oct 10, 2023
21 checks passed
@vtavana vtavana deleted the abs_dpctl_to_dpnp branch October 10, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlad-perevezentsev vlad-perevezentsev vlad-perevezentsev left review comments

@antonwolfy antonwolfy antonwolfy approved these changes

@npolina4 npolina4 Awaiting requested review from npolina4

Assignees

@vtavana vtavana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vtavana @vlad-perevezentsev @antonwolfy