Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dpnp.astype function #1597

Merged
merged 6 commits into from
Oct 18, 2023
Merged

Update dpnp.astype function #1597

merged 6 commits into from
Oct 18, 2023

Conversation

npolina4
Copy link
Collaborator

Leverage dpctl.tensor.astype() implementation.
Clean up old implementation.
Refresh test_ndarray_copy_and_view.py test file.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

npolina4
npolina4 commented Oct 16, 2023
View reviewed changes
dpnp/dpnp_iface.py Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Oct 16, 2023 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

antonwolfy
antonwolfy reviewed Oct 17, 2023
View reviewed changes
dpnp/dpnp_array.py Show resolved Hide resolved
dpnp/dpnp_array.py Outdated Show resolved Hide resolved
dpnp/dpnp_array.py Show resolved Hide resolved
dpnp/dpnp_iface.py Outdated Show resolved Hide resolved
dpnp/dpnp_array.py Outdated Show resolved Hide resolved
tests/third_party/cupy/core_tests/test_ndarray_copy_and_view.py Outdated Show resolved Hide resolved
tests/third_party/cupy/core_tests/test_ndarray_copy_and_view.py Outdated Show resolved Hide resolved
tests/third_party/cupy/core_tests/test_ndarray_copy_and_view.py Outdated Show resolved Hide resolved
tests/third_party/cupy/core_tests/test_ndarray_copy_and_view.py Outdated Show resolved Hide resolved
tests/skipped_tests_gpu.tbl Outdated Show resolved Hide resolved
@npolina4
Copy link
Collaborator Author

Tests for flatten will unmute in next PR

antonwolfy
antonwolfy approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @npolina4

@npolina4 npolina4 merged commit 7bbbf1a into master Oct 18, 2023
22 checks passed
@npolina4 npolina4 deleted the update_astype branch October 18, 2023 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@vtavana vtavana Awaiting requested review from vtavana vtavana is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@npolina4 @antonwolfy