Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented dpnp.can_cast function #1600

Merged
merged 5 commits into from
Oct 19, 2023
Merged

Implemented dpnp.can_cast function #1600

merged 5 commits into from
Oct 19, 2023

Conversation

npolina4
Copy link
Collaborator

Implemented dpnp.can_cast function and added tests.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@npolina4 npolina4 requested a review from antonwolfy October 17, 2023 17:26
@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2023 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

antonwolfy
antonwolfy reviewed Oct 18, 2023
View reviewed changes
dpnp/dpnp_iface_manipulation.py Show resolved Hide resolved
dpnp/dpnp_iface_manipulation.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_manipulation.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_manipulation.py Show resolved Hide resolved
tests/test_arraymanipulation.py Show resolved Hide resolved
npolina4 and others added 3 commits October 18, 2023 13:10
@npolina4 @antonwolfy
Update tests/third_party/cupy/test_type_routines.py
ec78865 
Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com>
@npolina4 @antonwolfy
Update tests/third_party/cupy/test_type_routines.py
c9b02dd 
Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com>
@npolina4
Merge branch 'master' into implement_can_cast
a0c6f86
antonwolfy
antonwolfy approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @npolina4

@antonwolfy antonwolfy merged commit f58d19d into master Oct 19, 2023
22 checks passed
@antonwolfy antonwolfy deleted the implement_can_cast branch October 19, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@npolina4 @antonwolfy