Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update dpnp.vdot implementation #1692

Merged
merged 4 commits into from
Feb 7, 2024
Merged

update dpnp.vdot implementation #1692

merged 4 commits into from
Feb 7, 2024

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Feb 5, 2024

In this PR, dpnp.vdot is updated. 1) For integer and boolean data types, dpctl.tensor.vecdot form the Data Parallel Control library is used, 2) For real-valued floating point data types, dot routines from BLAS library of OneMKL are used, and 3) For complex data types, dotc routines from BLAS library of OneMKL are used.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavana vtavana self-assigned this Feb 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 5, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/pull//index.html

@vtavana vtavana marked this pull request as ready for review February 6, 2024 00:37
Base automatically changed from dpnp_dot to master February 6, 2024 12:06
antonwolfy
antonwolfy reviewed Feb 7, 2024
View reviewed changes
dpnp/dpnp_iface_linearalgebra.py Show resolved Hide resolved
dpnp/dpnp_iface_linearalgebra.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_linearalgebra.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_linearalgebra.py Outdated Show resolved Hide resolved
dpnp/dpnp_utils/dpnp_utils_linearalgebra.py Outdated Show resolved Hide resolved
antonwolfy
antonwolfy approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtavana! No more comments from me.

@vtavana vtavana merged commit 1a3866e into master Feb 7, 2024
45 checks passed
@vtavana vtavana deleted the dpnp_vdot branch February 7, 2024 23:38
github-actions bot added a commit that referenced this pull request Feb 8, 2024
@github-actions
update dpnp.vdot implementation (#1692)
4ea5a29 
* update dpnp_vdot

* address comments

* address more comments 1a3866e
@antonwolfy antonwolfy mentioned this pull request Feb 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

Assignees

@vtavana vtavana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vtavana @antonwolfy