Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dpnp.linalg.tensorinv() implementation #1752

Merged
merged 4 commits into from
Mar 22, 2024
Merged

Add dpnp.linalg.tensorinv() implementation #1752

merged 4 commits into from
Mar 22, 2024

Conversation

vlad-perevezentsev
Copy link
Collaborator

This PR adds a new dpnp.linalg.tensorinv() function to calculate the inverse of input tensor arrray using dpnp.linalg.inv().
The changes are related to support of all types.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vlad-perevezentsev vlad-perevezentsev self-assigned this Mar 20, 2024
@vlad-perevezentsev vlad-perevezentsev changed the title Add dpnp.linalg.tensorinv implementation Add dpnp.linalg.tensorinv() implementation Mar 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 20, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

antonwolfy
antonwolfy approved these changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vlad-perevezentsev.
I only have a couple of minor comments.

dpnp/linalg/dpnp_iface_linalg.py Show resolved Hide resolved
dpnp/linalg/dpnp_iface_linalg.py Show resolved Hide resolved
@antonwolfy antonwolfy merged commit e5d3127 into master Mar 22, 2024
45 checks passed
@antonwolfy antonwolfy deleted the impl_tensorinv branch March 22, 2024 15:33
vlad-perevezentsev added a commit that referenced this pull request Mar 22, 2024
@vlad-perevezentsev
Address remarks for #1752
eac1523
antonwolfy pushed a commit that referenced this pull request Mar 23, 2024
@vlad-perevezentsev
Add dpnp.linalg.tensorsolve() implementation (#1753)
7ca1aff 
* add dpnp.linalg.tensorsolve impl

* Add tests for tensorsolve

* Add test_tensorsolve_axes

* Address remarks

* Address remarks for #1752
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@npolina4 npolina4 Awaiting requested review from npolina4

@vtavana vtavana Awaiting requested review from vtavana vtavana is a code owner

Assignees

@vlad-perevezentsev vlad-perevezentsev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vlad-perevezentsev @antonwolfy