Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for axes as list in dpnp.ndarray.transpose #1770

Merged
merged 6 commits into from
Apr 3, 2024
Merged

add support for axes as list in dpnp.ndarray.transpose #1770

merged 6 commits into from
Apr 3, 2024

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Apr 2, 2024

In this PR, dpnp.ndarray.transpose is updated to support axes as list and new tests are added. This PR resolves #1769.
In addition, tests/third_party/cupy/manipulation_tests/test_transpose.py is updated to the most recent version.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavana vtavana self-assigned this Apr 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 2, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@vtavana vtavana marked this pull request as ready for review April 2, 2024 16:44
@vtavana vtavana requested a review from antonwolfy April 2, 2024 16:48
@vtavana vtavana force-pushed the transpose_axes_list branch from da0ae2a to a782a1d Compare April 2, 2024 20:23
antonwolfy
antonwolfy approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtavana for catching that and improving the coverage and documentation.

@antonwolfy antonwolfy merged commit 5f99f4e into master Apr 3, 2024
45 checks passed
@antonwolfy antonwolfy deleted the transpose_axes_list branch April 3, 2024 10:54
github-actions bot added a commit that referenced this pull request Apr 3, 2024
@github-actions
add support for axes as list in dpnp.ndarray.transpose (#1770)
ef1b352 
* support axes as list

* fix a bug

* update description

* fix docstring when bullet is used 5f99f4e
github-actions bot added a commit to antonwolfy/dpnp that referenced this pull request Apr 3, 2024
@github-actions
add support for axes as list in dpnp.ndarray.transpose (IntelPyth…
a508c72 
…on#1770)

* support axes as list

* fix a bug

* update description

* fix docstring when bullet is used 5f99f4e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

Assignees

@vtavana vtavana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dpnp.ndarray.transpose does not support axes as list
2 participants
@vtavana @antonwolfy