Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update dpnp.cond #1773

Merged
merged 9 commits into from
Apr 8, 2024
Merged

update dpnp.cond #1773

merged 9 commits into from
Apr 8, 2024

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Apr 3, 2024

In this PR, dpnp.cond is updated using existing functions in dpnp.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavana vtavana self-assigned this Apr 3, 2024
@vtavana vtavana marked this pull request as ready for review April 3, 2024 05:27
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 3, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

antonwolfy
antonwolfy reviewed Apr 3, 2024
View reviewed changes
dpnp/linalg/dpnp_iface_linalg.py Outdated Show resolved Hide resolved
dpnp/linalg/dpnp_iface_linalg.py Outdated Show resolved Hide resolved
dpnp/linalg/dpnp_iface_linalg.py Outdated Show resolved Hide resolved
dpnp/linalg/dpnp_iface_linalg.py Outdated Show resolved Hide resolved
dpnp/linalg/dpnp_iface_linalg.py Outdated Show resolved Hide resolved
dpnp/linalg/dpnp_iface_linalg.py Outdated Show resolved Hide resolved
dpnp/linalg/dpnp_utils_linalg.py Show resolved Hide resolved
dpnp/linalg/dpnp_utils_linalg.py Outdated Show resolved Hide resolved
dpnp/linalg/dpnp_utils_linalg.py Outdated Show resolved Hide resolved
dpnp/linalg/dpnp_iface_linalg.py Outdated Show resolved Hide resolved
antonwolfy
antonwolfy approved these changes Apr 6, 2024
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtavana, LGTM!
I have only one minor comment which can be addressed by any other PR.

dpnp/linalg/dpnp_utils_linalg.py Outdated Show resolved Hide resolved
@vtavana vtavana merged commit 50b177d into master Apr 8, 2024
45 checks passed
@vtavana vtavana deleted the dpnp_cond branch April 8, 2024 16:42
github-actions bot added a commit that referenced this pull request Apr 8, 2024
@github-actions
update dpnp.cond (#1773)
b37e708 
* update dpnp.cond

* address comments

* update pinv function

* Update dpnp/linalg/dpnp_utils_linalg.py

---------

Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com> 50b177d
github-actions bot added a commit to antonwolfy/dpnp that referenced this pull request Apr 8, 2024
@github-actions
update dpnp.cond (IntelPython#1773)
e79280b 
* update dpnp.cond

* address comments

* update pinv function

* Update dpnp/linalg/dpnp_utils_linalg.py

---------

Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com> 50b177d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@npolina4 npolina4 Awaiting requested review from npolina4

Assignees

@vtavana vtavana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vtavana @antonwolfy