Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add implementation of dpnp.histogram #1785

Merged
merged 13 commits into from
Apr 29, 2024
Merged

Add implementation of dpnp.histogram #1785

merged 13 commits into from
Apr 29, 2024

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Apr 15, 2024

The PR is about to add implementation of dpnp.histogram function.
In the first step there is no dedicated kernel for uniform bins, since no bincount available in dpnp, but TODO comment placed to implement that later.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Apr 15, 2024
Copy link
Contributor

github-actions bot commented Apr 15, 2024

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@antonwolfy antonwolfy marked this pull request as ready for review April 24, 2024 13:04
dpnp/dpnp_iface_histograms.py Show resolved Hide resolved
dpnp/dpnp_iface_histograms.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_histograms.py Show resolved Hide resolved
dpnp/dpnp_iface_histograms.py Show resolved Hide resolved
dpnp/dpnp_iface_histograms.py Show resolved Hide resolved
tests/test_histogram.py Show resolved Hide resolved
dpnp/dpnp_iface_histograms.py Show resolved Hide resolved
dpnp/dpnp_iface_histograms.py Outdated Show resolved Hide resolved
@vlad-perevezentsev vlad-perevezentsev self-requested a review April 29, 2024 11:57
Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thank you @antonwolfy

@antonwolfy antonwolfy merged commit 8d04592 into master Apr 29, 2024
56 checks passed
@antonwolfy antonwolfy deleted the impl_histogram branch April 29, 2024 12:57
github-actions bot added a commit that referenced this pull request Apr 29, 2024
* Implement dpnp.histogram

* Updated third party tests for histogram

* Updated histogram tests due to new dpnp.cumsum() impl

* Applied pre-commit checks

* Added dpnp tests

* Added CFD tests

* Renamed test_histogram.py

* Updated tests to run on Iris Xe

* Get rid of block size

* Addressed review comments

* Leftovers from rebase

* Cast bin edges to default floating type if density is enabled 8d04592
github-actions bot added a commit to antonwolfy/dpnp that referenced this pull request Apr 29, 2024
* Implement dpnp.histogram

* Updated third party tests for histogram

* Updated histogram tests due to new dpnp.cumsum() impl

* Applied pre-commit checks

* Added dpnp tests

* Added CFD tests

* Renamed test_histogram.py

* Updated tests to run on Iris Xe

* Get rid of block size

* Addressed review comments

* Leftovers from rebase

* Cast bin edges to default floating type if density is enabled 8d04592
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants