Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leverage dpnp.trace implementation through existing calls #1842

Merged
merged 1 commit into from
May 22, 2024
Merged

Leverage dpnp.trace implementation through existing calls #1842

merged 1 commit into from
May 22, 2024

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented May 21, 2024 •
edited
Loading

The PR proposes to implement dpnp.trace through two consequence call of diagonal and sum functions.
The similar approach is implemented in numpy and cupy.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this May 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

View rendered docs @ https://intelpython.github.io/dpnp/pull/1842/index.html

vtavana
vtavana approved these changes May 21, 2024
View reviewed changes
Copy link
Collaborator

@vtavana vtavana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @antonwolfy!

@antonwolfy antonwolfy merged commit b988e9c into master May 22, 2024
52 of 56 checks passed
@antonwolfy antonwolfy deleted the impl_trace branch May 22, 2024 08:58
github-actions bot added a commit that referenced this pull request May 22, 2024
@github-actions
Add implementation of dpnp.trace (#1842) b988e9c
44757a3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtavana vtavana vtavana approved these changes

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@npolina4 npolina4 Awaiting requested review from npolina4

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonwolfy @vtavana