Skip to content

Remove skip in test_digitize #1851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2024
Merged

Remove skip in test_digitize #1851

merged 1 commit into from
May 23, 2024

Conversation

@vlad-perevezentsev
Copy link
Contributor

@vlad-perevezentsev vlad-perevezentsev commented May 23, 2024

This PR suggests removing a previously skipped test in TestDigitize in case when shape =() and increasing=False since #1689 is resolved and dpctl package with this fix is available in the internal channel.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vlad-perevezentsev vlad-perevezentsev self-assigned this May 23, 2024
antonwolfy
antonwolfy approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vlad-perevezentsev

@github-actions
Copy link
Contributor

github-actions bot commented May 23, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@antonwolfy antonwolfy mentioned this pull request May 23, 2024
Merged
6 tasks
@antonwolfy antonwolfy merged commit 7afd98d into master May 23, 2024
@antonwolfy antonwolfy deleted the unskip_digitize_test branch May 23, 2024 18:35
github-actions bot added a commit that referenced this pull request May 23, 2024
@github-actions
Remove skip in test_digitize (#1851) 7afd98d
2f3d82e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

Assignees

@vlad-perevezentsev vlad-perevezentsev

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vlad-perevezentsev @antonwolfy