Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up legacy element-wise implementation from the backend #1890

Merged
merged 9 commits into from
Jun 28, 2024
Merged

Clean up legacy element-wise implementation from the backend #1890

merged 9 commits into from
Jun 28, 2024

Conversation

npolina4
Copy link
Collaborator

@npolina4 npolina4 commented Jun 18, 2024 •
edited by antonwolfy
Loading

Cleaned up legacy element-wise implementation from the backend for speed up build and improve code coverage.

Changes was tested with numda-dpex component.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 18, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

antonwolfy
antonwolfy approved these changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @npolina4 , it's very helpful change.

@antonwolfy antonwolfy merged commit a265663 into master Jun 28, 2024
12 of 37 checks passed
@antonwolfy antonwolfy deleted the cleanup_elementwise branch June 28, 2024 11:44
github-actions bot added a commit that referenced this pull request Jun 28, 2024
@github-actions @antonwolfy
Clean up legacy element-wise implementation from the backend (#1890)
610b010 
* Clean up legacy element-wise implementation from the backend

* return legacy copy implementation for partition function

* Apply comments

* Fix pre-commit

* Fix pre-commit

* Clean-up MACRO_2ARG_2TYPES_LOGIC_OP. Clean-up /backend/include

---------

Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com>
Co-authored-by: Anton Volkov <antonwolfy@gmail.com> a265663
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@vtavana vtavana Awaiting requested review from vtavana vtavana is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@npolina4 @antonwolfy