Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support out parameter for dpnp.all/any() #1893

Merged
merged 6 commits into from
Jun 26, 2024
Merged

Support out parameter for dpnp.all/any() #1893

merged 6 commits into from
Jun 26, 2024

Conversation

vlad-perevezentsev
Copy link
Collaborator

This PR suggests adding support out parameter for dpnp.all() and dpnp.any() functions using dpnp.get_result_array() as a W/A until dpctl adds support out parameter.
This also updates docstings and adds new tests to cover the new implementation

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vlad-perevezentsev vlad-perevezentsev self-assigned this Jun 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 24, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

vtavana
vtavana reviewed Jun 25, 2024
View reviewed changes
dpnp/dpnp_iface_logic.py Show resolved Hide resolved
dpnp/dpnp_iface_logic.py Outdated Show resolved Hide resolved
dpnp/dpnp_iface_logic.py Show resolved Hide resolved
vtavana
vtavana approved these changes Jun 26, 2024
View reviewed changes
Copy link
Collaborator

@vtavana vtavana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @vlad-perevezentsev!

@antonwolfy antonwolfy merged commit 323ce50 into master Jun 26, 2024
57 of 67 checks passed
@antonwolfy antonwolfy deleted the update_all_any branch June 26, 2024 18:44
github-actions bot added a commit that referenced this pull request Jun 26, 2024
@github-actions
Support out parameter for dpnp.all/any() (#1893)
9faf6b0 
* Update dpnp.all/any with support out param

* Update cupy tests

* Add TestAllAny

* Update dpnp tests

* Apply comments

---------

Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com> 323ce50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtavana vtavana vtavana approved these changes

@antonwolfy antonwolfy antonwolfy approved these changes

@npolina4 npolina4 Awaiting requested review from npolina4

Assignees

@vlad-perevezentsev vlad-perevezentsev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vlad-perevezentsev @antonwolfy @vtavana