Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove obsolete dparray interface #1915

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Remove obsolete dparray interface #1915

merged 2 commits into from
Jul 9, 2024

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Jul 8, 2024 •
edited
Loading

dpnp.dparray interface is obsolete and has not been updated for a long time. It's not assumed to be used.
Instead here is dpnp.ndarray interface which is aligning with numpy.ndarray one.

The PR proposes to clean the code and to remove the obsolete interface.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Jul 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 8, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@antonwolfy antonwolfy merged commit eacaa5d into master Jul 9, 2024
39 of 45 checks passed
@antonwolfy antonwolfy deleted the remove-obsolete-dparray-if branch July 9, 2024 18:05
github-actions bot added a commit that referenced this pull request Jul 9, 2024
@github-actions
Remove obsolete dparray interface (#1915)
348ca44 
* Remove obsolete dparray i/f

* Rename test scope eacaa5d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@npolina4 npolina4 npolina4 approved these changes

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@vtavana vtavana Awaiting requested review from vtavana vtavana is a code owner

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonwolfy @npolina4