Skip to content

Conversation

@antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Jul 24, 2024

The PR adds implementation of dpnp.trim_zeros function.

All test scenarios are covered with new tests. Additionally tests/third_party/cupy/manipulation_tests/test_add_remove.py is included to verify with third party tests.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Jul 24, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Jul 24, 2024

View rendered docs @ https://intelpython.github.io/dpnp/index.html

Copy link
Contributor

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thank you @antonwolfy

@antonwolfy antonwolfy merged commit d6c0c0a into master Jul 25, 2024
@antonwolfy antonwolfy deleted the impl_trim_zeros branch July 25, 2024 10:34
github-actions bot added a commit that referenced this pull request Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants