Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dpnp.trim_zeros implementation #1941

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Add dpnp.trim_zeros implementation #1941

merged 1 commit into from
Jul 25, 2024

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Jul 24, 2024 •
edited
Loading

The PR adds implementation of dpnp.trim_zeros function.

All test scenarios are covered with new tests. Additionally tests/third_party/cupy/manipulation_tests/test_add_remove.py is included to verify with third party tests.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Jul 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 24, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

vlad-perevezentsev
vlad-perevezentsev approved these changes Jul 25, 2024
View reviewed changes
Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thank you @antonwolfy

@antonwolfy antonwolfy merged commit d6c0c0a into master Jul 25, 2024
39 of 45 checks passed
@antonwolfy antonwolfy deleted the impl_trim_zeros branch July 25, 2024 10:34
github-actions bot added a commit that referenced this pull request Jul 25, 2024
@github-actions
Implement dpnp.trim_zeros() (#1941) d6c0c0a
3ff5397
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlad-perevezentsev vlad-perevezentsev vlad-perevezentsev approved these changes

@npolina4 npolina4 Awaiting requested review from npolina4

@vtavana vtavana Awaiting requested review from vtavana vtavana is a code owner

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonwolfy @vlad-perevezentsev